[PATCH] D105709: [AMDGPU][GlobalISel] Insert an and with exec before s_cbranch_vccnz if necessary

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 09:04:16 PDT 2021


foad added a comment.

In D105709#2910506 <https://reviews.llvm.org/D105709#2910506>, @mbrkusanin wrote:

> - Covered case with amdgcn_ballot.

No, ballot is a weird thing that returns the full 32/64-bit result of evaluating an expression in all lanes. You should not handle it here. I meant to approve the previous version of the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105709/new/

https://reviews.llvm.org/D105709



More information about the llvm-commits mailing list