[PATCH] D105709: [AMDGPU][GlobalISel] Insert an and with exec before s_cbranch_vccnz if necessary

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 09:02:28 PDT 2021


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks OK to me, just one suggestion inline.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:2518-2519
+      const bool Is64 = STI.isWave64();
+      const TargetRegisterClass *RC =
+          Is64 ? &AMDGPU::SReg_64RegClass : &AMDGPU::SReg_32RegClass;
+      const unsigned Opcode = Is64 ? AMDGPU::S_AND_B64 : AMDGPU::S_AND_B32;
----------------
Use `TRI.getBoolRC`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105709/new/

https://reviews.llvm.org/D105709



More information about the llvm-commits mailing list