[PATCH] D106139: [DAGCombine] Combine srX of add that intends to get the carry as uaddo

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D106139#2909346 <https://reviews.llvm.org/D106139#2909346>, @abinavpp wrote:

> @lebedev.ri Can you confirm the revision you require in this?



> Is there an issue with the code in this patch and/or do you want us to move this to inst-combine?
> I still agree with @arsenm that this sort of thing might need to be done in both the places, in which case I don't see any issue in the order in which we push for it.

I agree that we might need to do this in both the places, emphasis is mine,
but mainly this should be done in middle-end, and afterwards the back-end fold
should be motivated by an end-to-end test showing the missed optimization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106139/new/

https://reviews.llvm.org/D106139