[PATCH] D105871: Followup to D99355: implementation of sdag support for vp load/store/gather/scatter.

[Hussain Kadhem via Phabricator via llvm-commits]

hussainjk added a comment.

In D105871#2904152 <https://reviews.llvm.org/D105871#2904152>, @frasercrmck wrote:

> This patch also needs to extend `SelectionDAGBuilder` to custom-build the "mem" nodes from the intrinsics. Otherwise we won't be creating the `SDNode`s correctly, e.g. there'll be an invalid `MachineMemOperand`.

As far as I can tell, this is being done correctly through `SelectionDAGBuilder::visitVectorPredicationIntrinsic`. Is this not the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105871/new/

https://reviews.llvm.org/D105871