[PATCH] D106722: [Matrix] Fix shape for factored transpose

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

In D106722#2905390 <https://reviews.llvm.org/D106722#2905390>, @fhahn wrote:

> LGTM, thanks!

Thanks for the reviews.

> It’s a bit unfortunate that we need to maintain the shapes and also explicitly pass the dimensions to the builder. Could we make this more robust (as follow up) by passing a struct with (vale *, rows, columns) to to builders and those structure are obtained from the shape map directly?

Yeah we can explore this.  It will somewhat change the interface for something like matmul but it’s a possibility.

Ultimately the best would be if we didn’t have to write the unit tests for a matrix -> matrix transformation in terms of matrix -> vector (i.e. including lowering) but as a matrix -> matrix transformation (i.e. we would split these optimizations into their own pass).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106722/new/

https://reviews.llvm.org/D106722