[PATCH] D106722: [Matrix] Fix shape for factored transpose
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 26 12:59:05 PDT 2021
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
It’s a bit unfortunate that we need to maintain the shapes and also explicitly pass the dimensions to the builder. Could we make this more robust (as follow up) by passing a struct with (vale *, rows, columns) to to builders and those structure are obtained from the shape map directly?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106722/new/
https://reviews.llvm.org/D106722
More information about the llvm-commits
mailing list