[PATCH] D105528: [RuntimeDyldChecker] Support offset in decode_operand expr

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

In D105528#2903836 <https://reviews.llvm.org/D105528#2903836>, @luismarques wrote:

> LGTM.
>
> Note: I don't know what is the current standard for the ExecutionEngine test exhaustiveness, but the error condition, the subtracted offset, and the invalid offset cases aren't exercised in the tests.

Testing of the ExecutionEngine libraries is basic (though reasonably effective) -- definitely not exhaustive, but improving.

Testing of the test infrastructure itself (e.g. the jitlink checker) is currently non-existent.

Improving library testing is the higher priority, but more testing of the test tools would be nice too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105528/new/

https://reviews.llvm.org/D105528