[PATCH] D105528: [RuntimeDyldChecker] Support offset in decode_operand expr

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 26 02:53:42 PDT 2021


luismarques added a comment.

LGTM.

Note: I don't know what is the current standard for the ExecutionEngine test exhaustiveness, but the error condition, the subtracted offset, and the invalid offset cases aren't exercised in the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105528/new/

https://reviews.llvm.org/D105528



More information about the llvm-commits mailing list