[PATCH] D106812: [PowerPC] Fix materialization of SP float values on Power10

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:415
+  APFloatOfN.convert(APFloat::IEEEdouble(), APFloat::rmNearestTiesToEven,
+                     &LosesInfo);
   uint32_t Hi = (uint32_t)((APFloatOfN.bitcastToAPInt().getZExtValue() &
----------------
NeHuang wrote:
> Do we need to check `LosesInfo` to ensure lossless conversion? 
IIUC It is not possible for a value to be representable in single precision but not double precision. I suppose we can add:
`assert(!LosesInfo && "conversion from SP to DP loses info?")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106812/new/

https://reviews.llvm.org/D106812