[PATCH] D106812: [PowerPC] Fix materialization of SP float values on Power10

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:415
+  APFloatOfN.convert(APFloat::IEEEdouble(), APFloat::rmNearestTiesToEven,
+                     &LosesInfo);
   uint32_t Hi = (uint32_t)((APFloatOfN.bitcastToAPInt().getZExtValue() &
----------------
Do we need to check `LosesInfo` to ensure lossless conversion? 


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:426
+  APFloatOfN.convert(APFloat::IEEEdouble(), APFloat::rmNearestTiesToEven,
+                     &LosesInfo);
   uint32_t Lo = (uint32_t)(APFloatOfN.bitcastToAPInt().getZExtValue() &
----------------
same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106812/new/

https://reviews.llvm.org/D106812