[PATCH] D106782: [llvm-objcopy] Drop GRP_COMDAT if the group signature is localized

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/group.test:120
+    Link:            .symtab
+    AddressAlign:    0x0000000000000004
+    Info:            foo
----------------
Seems like you can drop this? (possibly also the Link field, but I don't remember what the default is for group sections).


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/group.test:127
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR, SHF_GROUP ]
+Symbols:
----------------
Perhaps simplify to just `[SHF_GROUP]`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106782/new/

https://reviews.llvm.org/D106782