[PATCH] D106782: [llvm-objcopy] Drop GRP_COMDAT if the group signature is localized

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/group.test:91
+## The signature symbol is non-local. Keep GRP_COMDAT.
+# RUN: llvm-readelf -s --section-groups %t | FileCheck %s --check-prefix=WEAK-SIG
+
----------------
jhenderson wrote:
> This line is testing the yaml2obj output, which I don't think is what you want. Did you mean to dump `%t1` or do something else?
Ah, right. I intended to test `%t1`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106782/new/

https://reviews.llvm.org/D106782