[PATCH] D106781: [Zorg] Use ccache instead incremental build for openmp-offload-cuda-runtime.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur created this revision.
Meinersbur added reviewers: gkistanova, ye-luo, tianshilei1992.
Meinersbur added projects: OpenMP, Zorg.
Herald added subscribers: guansong, yaxunl.
Meinersbur requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

Building with `LLVM_ENABLE_RUNTIMES=openmp` has the disadvantage that if clang changes, the runtime that was built with the previous clang is not rebuilt. That is, if the runtime is miscompiling due to a change in clang, this will only be detected in the next clean build.

For instance, commit rG1100e4aafea233bc8bbc307c5758a7d287ad3bae <https://reviews.llvm.org/rG1100e4aafea233bc8bbc307c5758a7d287ad3bae> caused the libomptarget device runtime to miscompile, but the openmp-offload-cuda-runtime builder <https://lab.llvm.org/staging/#/builders/154/builds/1421> shows it as green. Tests only started failing with the next clean build <https://lab.llvm.org/staging/#/builders/154/builds/1427>. In production, this would have blamed the wrong commit.

In contrast, the openmp-offload-cuda-project builder started failing with the expected commit <https://lab.llvm.org/staging/#/builders/155/builds/1803>.

Instead of building incrementally, use ccache to avoid this problem.


Repository:
  rZORG LLVM Github Zorg

https://reviews.llvm.org/D106781

Files:
  buildbot/osuosl/master/config/builders.py


Index: buildbot/osuosl/master/config/builders.py
===================================================================
--- buildbot/osuosl/master/config/builders.py
+++ buildbot/osuosl/master/config/builders.py
@@ -1350,7 +1350,7 @@
     'workernames' : ["minipc-1050ti-linux"],
     'builddir': "openmp-offload-cuda-runtime",
     'factory' : OpenMPBuilder.getOpenMPCMakeBuildFactory(
-                        clean=False,
+                        clean=True,
                         enable_runtimes=['openmp'],
                         extraCmakeArgs=[
                                 "-DCUDA_TOOLKIT_ROOT_DIR=/opt/cuda",
@@ -1361,6 +1361,8 @@
                                 "-DLLVM_TARGETS_TO_BUILD=X86;NVPTX",
                                 "-DLLVM_ENABLE_LLD=ON",
                                 '-DLLVM_PARALLEL_LINK_JOBS=2',
+                                "-DCMAKE_C_COMPILER_LAUNCHER=ccache",
+                                "-DCMAKE_CXX_COMPILER_LAUNCHER=ccache",
                             ],
                         install=True,
                         testsuite=True,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106781.361572.patch
Type: text/x-patch
Size: 1093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210726/b708eb32/attachment.bin>