[PATCH] D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog
Kyungwoo Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 24 21:08:51 PDT 2021
kyulee updated this revision to Diff 361488.
kyulee marked 2 inline comments as done.
kyulee added a comment.
Update the change per feedbacks.
- Add sub/add pair check.
- Check against the one target.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106760/new/
https://reviews.llvm.org/D106760
Files:
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
llvm/test/CodeGen/AArch64/homogeneous-prolog-epilog-local.ll
Index: llvm/test/CodeGen/AArch64/homogeneous-prolog-epilog-local.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/homogeneous-prolog-epilog-local.ll
@@ -0,0 +1,23 @@
+; RUN: llc < %s -mtriple=arm64-apple-ios7.0 -homogeneous-prolog-epilog | FileCheck %s
+
+; CHECK-LABEL: _foo:
+; CHECK: sub sp, sp, #16
+; CHECK: bl _goo
+; CHECK: add sp, sp, #16
+
+define i32 @foo(i32 %c) nounwind minsize {
+entry:
+ %buffer = alloca [1 x i32], align 4
+ %0 = bitcast [1 x i32]* %buffer to i8*
+ call void @llvm.lifetime.start.p0i8(i64 4, i8* nonnull %0)
+ %arraydecay = getelementptr inbounds [1 x i32], [1 x i32]* %buffer, i64 0, i64 0
+ %call = call i32 @goo(i32* nonnull %arraydecay)
+ %sub = sub nsw i32 %c, %call
+ call void @llvm.lifetime.end.p0i8(i64 4, i8* nonnull %0)
+
+ ret i32 %sub
+}
+
+declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture)
+declare i32 @goo(i32*)
+declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture)
Index: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
+++ llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
@@ -1738,7 +1738,7 @@
// Adjust local stack
emitFrameOffset(MBB, LastPopI, DL, AArch64::SP, AArch64::SP,
- StackOffset::getFixed(-AFI->getLocalStackSize()), TII,
+ StackOffset::getFixed(AFI->getLocalStackSize()), TII,
MachineInstr::FrameDestroy, false, NeedsWinCFI);
// SP has been already adjusted while restoring callee save regs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106760.361488.patch
Type: text/x-patch
Size: 1680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210725/e310a525/attachment.bin>
More information about the llvm-commits
mailing list