[PATCH] D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

LG



================
Comment at: llvm/test/CodeGen/AArch64/homogeneous-prolog-epilog-local.ll:1
+; RUN: llc < %s -mtriple=arm64-apple-ios7.0  -homogeneous-prolog-epilog | FileCheck %s
+; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu  -homogeneous-prolog-epilog | FileCheck %s --check-prefixes=CHECK-LINUX
----------------
hmm, i don't know whether it is necessary to explicitly test two configurations. having one seems sufficient.


================
Comment at: llvm/test/CodeGen/AArch64/homogeneous-prolog-epilog-local.ll:5
+; CHECK-LABEL: _foo:
+; CHECK:        bl  _goo
+; CHECK:        add sp, sp, #16
----------------
It's useful to check `sub` as well because the intention is to check the sub+add pair.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106760/new/

https://reviews.llvm.org/D106760