[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

The commit message needs rewriting to reflect the final patch. Also, "Explicitly target-abi encoded in IR is clear than empty target-abi." is wrong, it's not about clarity, it's about robustness and correctness.



================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:232
 
+  // Use the explicitly target-feature to compute default ABI.
+  if (ABI.empty())
----------------
I don't think this warrants a comment, and the current grammar is a bit dodgy, but if you still want one: "Compute the default ABI based on the target features"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105555/new/

https://reviews.llvm.org/D105555