[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 10:47:09 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/Support/TargetParser.cpp:341-344
+  }
+  if (ISAInfo.hasExtension("d"))
+    return "lp64d";
+  return "lp64";
----------------
makes me feel more comfortable inside, and also is a bit more like the old code where we did explicitly check 32 and 64 (though that instead fell back on the next step, rather than asserting).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105555/new/

https://reviews.llvm.org/D105555



More information about the llvm-commits mailing list