[PATCH] D106598: [llvm-rc] Allow dashes as part of resource name strings

Fri Jul 23 10:36:42 PDT 2021

mstorsjo added a comment.

In D106598#2900772 <https://reviews.llvm.org/D106598#2900772>, @jeremyd2019 wrote:

> In D106598#2900656 <https://reviews.llvm.org/D106598#2900656>, @mstorsjo wrote:
>
>> Yep. This seems to be used by some project in the form `ice40/chipdb-384.bin RCDATA "path/to/ice40/chipdb-384.bin"` (see https://github.com/msys2/MINGW-packages/issues/9180). (Also some projects include filenames without quotes, e.g. `40 RCDATA unquoted-filename-with-dashes.ico` as one identifier.)
>
> It's even worse than that because there is no whitespace/newlines between entries: `ice40/chipdb-384.bin RCDATA "T:/mingw-w64-nextpnr/src/nextpnr/ice40/chipdb/chipdb-384.bin"ice40/chipdb-1k.bin RCDATA "T:/mingw-w64-nextpnr/src/nextpnr/ice40/chipdb/chipdb-1k.bin"ice40/...`.  So it must be auto-generated, no sane human would maintain a file like that.

Oh, that’s absolutely terrible. Based on the error messages, I think the cmake files generate it. Regardless of this change, I think it’d be good to upstream a fix to them to at least add newlines inbetween.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106598/new/

https://reviews.llvm.org/D106598