[PATCH] D106598: [llvm-rc] Allow dashes as part of resource name strings

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 23 10:18:16 PDT 2021


mstorsjo added a comment.

In D106598#2900730 <https://reviews.llvm.org/D106598#2900730>, @amccarth wrote:

> I see.  I didn't realize llvm-rc used an actual separate preprocessor step.  (RC has a crude one built-in that doesn't quite match any of the standards.)

Yup, I’ve also observed that the rc.exe built in one is a bit special. Llvm-rc didn’t use to have preprocessing at all before (you had to construct your own tool that did preprocessing manually beforehand, then calling llvm-rc), but as of recently, it can call clang as a subprocess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106598/new/

https://reviews.llvm.org/D106598



More information about the llvm-commits mailing list