[PATCH] D106557: [DebugInfo] Fix crash when updating DBG_VALUE users of an SSA value modified by tail duplication
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 23 06:27:12 PDT 2021
StephenTozer added inline comments.
================
Comment at: llvm/test/CodeGen/X86/tail-dup-debugvalue.mir:3-4
+
+# Tail Duplication may update SSA values and invalidate any DBG_VALUEs that
+# use those values; those DBG_VALUEs should be deleted.
+
----------------
jmorse wrote:
> IMO: this should explicitly state that multiple identical operands is what's being tested, lest someone revises it in the future and doesn't know the objective.
In this case it's not actually just testing that - it does explicitly test multiple operands, but it also looks as though the old behaviour wasn't well tested for, so this test covers both.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106557/new/
https://reviews.llvm.org/D106557
More information about the llvm-commits
mailing list