[PATCH] D106557: [DebugInfo] Fix crash when updating DBG_VALUE users of an SSA value modified by tail duplication

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM with some nits.



================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:238
       }
+      for (auto MI : InstrsToRemove)
+        MI->eraseFromParent();
----------------
I'd prefer the `auto *MI` form just for precision.


================
Comment at: llvm/test/CodeGen/X86/tail-dup-debugvalue.mir:3-4
+
+# Tail Duplication may update SSA values and invalidate any DBG_VALUEs that
+# use those values; those DBG_VALUEs should be deleted.
+
----------------
IMO: this should explicitly state that multiple identical operands is what's being tested, lest someone revises it in the future and doesn't know the objective.


================
Comment at: llvm/test/CodeGen/X86/tail-dup-debugvalue.mir:86
+liveins:         []
+frameInfo:
+  isFrameAddressTaken: false
----------------
Most if not all the frameInfo can be deleted, and all the "false" attributes above. Note also the --simplify-mir option to llc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106557/new/

https://reviews.llvm.org/D106557