[PATCH] D101727: Fix PR47960 - Incorrect transformation of fabs with nnan flag

Thu Jul 22 08:05:03 PDT 2021

spatel added a comment.

In D101727#2896447 <https://reviews.llvm.org/D101727#2896447>, @Krishnakariya wrote:

> Hi @spatel, 
> I am sorry for my delayed responses to this patch. I wanted to ask for some clarification on your previous comments.
> I have created few new tests similar to the original ones, with the only change that the FMF flag present in the fsub/fneg is now present on the select instruction. Original tests are left untouched. 
> Is this what you were expecting in your last comment?

Yes, that looks like better coverage. We'll need to adjust some test comments too. 
Please commit the extra tests with current CHECK line output (no code changes) to `main`. Then update this patch on top of that, so we will see the diffs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101727/new/

https://reviews.llvm.org/D101727