[PATCH] D101727: Fix PR47960 - Incorrect transformation of fabs with nnan flag

Krishna Kariya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 07:42:13 PDT 2021


Krishnakariya updated this revision to Diff 360809.
Krishnakariya added a comment.

Hi @spatel, 
I am sorry for my delayed responses to this patch. I wanted to ask for some clarification on your previous comments.
I have created few new tests similar to the original ones, with the only change that the FMF flag present in the fsub/fneg is now present on the select instruction. Original tests are left untouched. 
Is this what you were expecting in your last comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101727/new/

https://reviews.llvm.org/D101727

Files:
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/test/Transforms/InstCombine/fabs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101727.360809.patch
Type: text/x-patch
Size: 28382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210722/ca5b4f86/attachment.bin>


More information about the llvm-commits mailing list