[PATCH] D89009: Add version to libLLVM also on non-UNIX

Wed Jul 21 23:15:53 PDT 2021

mstorsjo added a comment.

In D89009#2895050 <https://reviews.llvm.org/D89009#2895050>, @mati865 wrote:

> I had no internet during the weekend (massive storms over here) but so I returned to it yesterday.
> I'm unable to build clean main branch at the moment:
>
>   `
>   [2972/3064] Linking CXX shared library bin\libLLVM.dll
>   FAILED: bin/libLLVM.dll lib/libLLVM.dll.a
>   cmd.exe /C "cd . && D:\msys64\clang64\bin\c++.exe -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,--gc-sections -shared -o bin\libLLVM.dll -Wl,--out-implib,lib\libLLVM.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles\LLVM.rsp  && cd ."
>   lld-link: error: too many exported symbols (max 65535)
>   `

Hmm, that’s a bit of a problem… Such a build does succeed for me at the moment, but I only have the x86, arm and aarch64 targets enabled. Then I end up with around 57k exported symbols from that DLL.

> It's simple change though, should I update diff without testing?

That’d be fine with me, I could test building with it.

I don’t have any testcase that would use llvm-config for finding the libs to link though (which is the case that this tries to fix, right?).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009