[PATCH] D89009: Add version to libLLVM also on non-UNIX

[Mateusz Mikuła via Phabricator via llvm-commits]

mati865 added a comment.

I had no internet during the weekend (massive storms over here) but so I returned to it yesterday.
I'm unable to build clean main branch at the moment:

  `
  [2972/3064] Linking CXX shared library bin\libLLVM.dll
  FAILED: bin/libLLVM.dll lib/libLLVM.dll.a
  cmd.exe /C "cd . && D:\msys64\clang64\bin\c++.exe -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,--gc-sections -shared -o bin\libLLVM.dll -Wl,--out-implib,lib\libLLVM.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles\LLVM.rsp  && cd ."
  lld-link: error: too many exported symbols (max 65535)
  `

It's simple change though, should I update diff without testing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009