[PATCH] D103935: Add Twine support for std::string_view.

[Justin Bogner via Phabricator via llvm-commits]

bogner added a comment.

Just ran into this issue (we were a bit behind on integrating upstream) - glad to see it's already fixed. Regarding the following:

> Reverting this patch might help in the instant case, but the odds of something similar happening, where the data structure is different across different versions of the standard is very hard to guarantee. And also hard to test for.

This particular case isn't a particularly egregious case of issues being hard to detect, given that it's an ABI change based on an ifdef - LLVM has a long history of avoiding doing this kind of thing (either through being compiler agnostic with `Compiler.h` or using `LLVM_ENABLE_ABI_BREAKING_CHECKS`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103935/new/

https://reviews.llvm.org/D103935