[PATCH] D106439: [OpenMP] Fold `__kmpc_is_generic_main_thread_id` if possible

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/OpenMP/fold_generic_main_thread.ll:39
+  ret void
+}
+
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > Shouldn't this be folded?
> It should be folded. I have `CHECK-NOT` because the only way that call can be removed is through the folding because it's only a declaration in the module. I couldn't decide if I should just use the automatic test script for this, personally I prefer tests like this to be narrow if possible.
check-not like above is really easy to break. Let's assume the type is changed, the name of the argument, etc.
If you want it narrow, check for `%pred = icmp eq i8 1, 1` or `br i1 true, label %if.then, label %if.end`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106439/new/

https://reviews.llvm.org/D106439