[PATCH] D106439: [OpenMP] Fold `__kmpc_is_generic_main_thread_id` if possible

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 21 07:45:51 PDT 2021


jhuber6 added inline comments.


================
Comment at: llvm/test/Transforms/OpenMP/fold_generic_main_thread.ll:39
+  ret void
+}
+
----------------
jdoerfert wrote:
> Shouldn't this be folded?
It should be folded. I have `CHECK-NOT` because the only way that call can be removed is through the folding because it's only a declaration in the module. I couldn't decide if I should just use the automatic test script for this, personally I prefer tests like this to be narrow if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106439/new/

https://reviews.llvm.org/D106439



More information about the llvm-commits mailing list