[llvm] a4904eb - [NFC][hwasan] Remove "pragma GCC poison"

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 19:10:26 PDT 2021


Author: Vitaly Buka
Date: 2021-07-20T19:10:05-07:00
New Revision: a4904ebb88e84bd86e1eda9c8e62eeb99273eada

URL: https://github.com/llvm/llvm-project/commit/a4904ebb88e84bd86e1eda9c8e62eeb99273eada
DIFF: https://github.com/llvm/llvm-project/commit/a4904ebb88e84bd86e1eda9c8e62eeb99273eada.diff

LOG: [NFC][hwasan] Remove "pragma GCC poison"

With ifdefs they make code less readable.

Added: 
    

Modified: 
    llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
index add89cb5442b..7b674b09fd05 100644
--- a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
@@ -194,26 +194,14 @@ namespace {
 
 bool shouldUsePageAliases(const Triple &TargetTriple) {
   return ClUsePageAliases && TargetTriple.getArch() == Triple::x86_64;
-#ifdef __GNUC__
-// No one should use the option directly.
-#pragma GCC poison ClUsePageAliases
-#endif
 }
 
 bool shouldInstrumentStack(const Triple &TargetTriple) {
   return !shouldUsePageAliases(TargetTriple) && ClInstrumentStack;
-#ifdef __GNUC__
-// No one should use the option directly.
-#pragma GCC poison ClInstrumentStack
-#endif
 }
 
 bool shouldInstrumentWithCalls(const Triple &TargetTriple) {
   return ClInstrumentWithCalls || TargetTriple.getArch() == Triple::x86_64;
-#ifdef __GNUC__
-// No one should use the option directly.
-#pragma GCC poison ClInstrumentWithCalls
-#endif
 }
 
 /// An instrumentation pass implementing detection of addressability bugs


        


More information about the llvm-commits mailing list