[PATCH] D106378: RISCV: relax the ABI mismatch checking
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 20 10:36:43 PDT 2021
jrtc27 added a comment.
In D106378#2891003 <https://reviews.llvm.org/D106378#2891003>, @MaskRay wrote:
> This needs linker&psABI discussions on what the best path forward.
>
> If we do need the lld/ELF change, we need to change `error` to `errorOrWarn` so that `--noinhibit-exec` without `--fatal-warnings` will be a warning...
The right path forward is to not use tools that create ELF files that don't adhere to the psABI (i.e. say they use one ABI when you mean for them to be another ABI). Whether that's by changing the tools to support specifying the ABI for the output file, or by using existing alternative tools (clang + .incbin / gcc + as + .incbin) that don't suffer from those shortcomings, I don't really care, but I see this as a tooling issue not an ABI issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106378/new/
https://reviews.llvm.org/D106378
More information about the llvm-commits
mailing list