[PATCH] D106378: RISCV: relax the ABI mismatch checking

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 10:32:28 PDT 2021


jrtc27 added a comment.

In D106378#2890957 <https://reviews.llvm.org/D106378#2890957>, @compnerd wrote:

> I agree that it is unfortunate that RISCV opted to put these flags into the `e_flags` field in the ELF header.  These are machine dependent and is ideally handled by something like `.riscv.attributes`.  In fact, ARM has such a model which does allow for the merging of the incompatible code, with a warning and all.  The problem here is that there is existing code which relies on this relaxed check.

Where the bits are makes no difference. It's solely a policy for how to interpret them. (Yes, there's also the fact that an ELF note has an additional state of "not present", but that can also be done with an e_flags bit, there is no fundamental difference between them).

e_flags is always machine dependent. I don't get your point there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106378/new/

https://reviews.llvm.org/D106378



More information about the llvm-commits mailing list