[PATCH] D105423: Add support for Opaque as a LowLevelType

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/unittests/CodeGen/LowLevelTypeTest.cpp:24
   DataLayout DL("");
 
+  for (unsigned S : {0U, 1U, 17U, 32U, 64U, 0xfffffU}) {
----------------
pmatos wrote:
> arsenm wrote:
> > I think we're missing an EXPECT_FALSE(LLT().isValid()) test
> Where do you expect this?
Ah, is this what you mean:

```
TEST(LowLevelTypeTest, Invalid) {
  const LLT Ty;

  ASSERT_FALSE(Ty.isValid());
```

Line 291 of this file.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105423/new/

https://reviews.llvm.org/D105423