[PATCH] D105417: [RISCV] Teach RISCVMatInt about cases where it can use LUI+SLLI to replace LUI+ADDI+SLLI for large constants.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 15:08:50 PDT 2021


luismarques added a comment.

In D105417#2874534 <https://reviews.llvm.org/D105417#2874534>, @craig.topper wrote:

> @luismarques were you able to find the change you were looking at to fix the add-before-shl.ll regression?

You can find it in D106318 <https://reviews.llvm.org/D106318>. If you find it useful just take it. Or let me know if you want me to elaborate more on some of the unexercised implementation details.

BTW, ignore my previous comment about it not being a localized fixed for the `isDesirableToCommuteWithShift`-related regression. When I wrote that I missed that (1) we did end up adopting a backtracking approach and that (2) the proposed cost function only needs to be used in `getIntMatCost` to address the regression, anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105417/new/

https://reviews.llvm.org/D105417



More information about the llvm-commits mailing list