[llvm] 904dab5 - GlobalISel: Remove some mystery code that clears isReturned
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 19 17:45:56 PDT 2021
Author: Matt Arsenault
Date: 2021-07-19T20:21:05-04:00
New Revision: 904dab55abf637586897f14573bf1182d5001a0e
URL: https://github.com/llvm/llvm-project/commit/904dab55abf637586897f14573bf1182d5001a0e
DIFF: https://github.com/llvm/llvm-project/commit/904dab55abf637586897f14573bf1182d5001a0e.diff
LOG: GlobalISel: Remove some mystery code that clears isReturned
I don't understand what this is going for, and haven't found an analog
in DAG code. No tests fail with this removed.
Added:
Modified:
llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp b/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
index 8dd544f28827..d2cda9ece31a 100644
--- a/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -588,16 +588,6 @@ bool CallLowering::determineAssignments(ValueAssigner &Assigner,
Flags.setSplitEnd();
}
- if (!Assigner.isIncomingArgumentHandler()) {
- // TODO: Also check if there is a valid extension that preserves the
- // bits. However currently this call lowering doesn't support non-exact
- // split parts, so that can't be tested.
- if (OrigFlags.isReturned() &&
- (NumParts * NewVT.getSizeInBits() != CurVT.getSizeInBits())) {
- Flags.setReturned(false);
- }
- }
-
Args[i].Flags.push_back(Flags);
if (Assigner.assignArg(i, CurVT, NewVT, NewVT, CCValAssign::Full, Args[i],
Args[i].Flags[Part], CCInfo)) {
More information about the llvm-commits
mailing list