[PATCH] D106128: [lld-macho] Use immediate encodings for bind opcodes

Mon Jul 19 13:55:58 PDT 2021

int3 added a comment.

one nit about the commit title / description: there are lots of opcodes with immediates, I think it would be clearer to mention `DO_BIND_ADD_ADDR_IMM_SCALED` specifically in the title. Also "Implement pass 3 of bind opcodes from ld64" should be followed by a short description of what pass 3 does -- we shouldn't expect future readers to have to look it up :)

================
Comment at: lld/test/MachO/bind-opcodes.s:1
 # REQUIRES: x86
 # RUN: rm -rf %t; split-file %s %t
----------------
almost forgot about this :) we need it now that we're building arm binaries

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106128/new/

https://reviews.llvm.org/D106128