[PATCH] D102039: [profile] Add binary id into profiles

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 13:08:47 PDT 2021


davidxl added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:92
+  int BinaryIdsSize = 0;
+  while (Note < NotesEnd) {
+    /*
----------------
Is it possible to extract this into a common helper function like

void ForEachNote(int note_type,  .. note_start, .. note_end,  ... call_back ) {
  ...

}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102039/new/

https://reviews.llvm.org/D102039



More information about the llvm-commits mailing list