[PATCH] D102039: [profile] Add binary id into profiles
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 19 12:54:10 PDT 2021
phosek added a comment.
@davidxl we split the indexed profile change out of this change since it's not necessary for us right now, would it be possible to take a look again?
================
Comment at: compiler-rt/include/profile/InstrProfData.inc:140
INSTR_PROF_RAW_HEADER(uint64_t, ValueKindLast, IPVK_Last)
+INSTR_PROF_RAW_HEADER(uint64_t, BinaryIdsSize, __llvm_write_binary_ids(NULL))
#undef INSTR_PROF_RAW_HEADER
----------------
I'd prefer to move this field just after `Version` before `DataSize` to match the order of data inside the profile.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102039/new/
https://reviews.llvm.org/D102039
More information about the llvm-commits
mailing list