[PATCH] D105657: [InstrRef][X86] Drop debug instruction numbers from x87 instructions

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 359723.
jmorse added a comment.

Stephen wrote:

> Quick question: Do call instructions need to be handled here? I tried modifying the C source to have a variable directly assigned from a call instruction:

Erk, that's right, those should indeed have instruction numbers dropped, it's being mutated and the operands don't mean the same things any more. This revision adds another drop call, and labels a call in the MIR with a debug-instr-number, to be dropped.

I suppose it's possible that, if a function returns more than one value, that we could un-necessarily drop non-float variable information where it could have been preserved. As far as I understand it, LLVM doesn't support multiple return values though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105657/new/

https://reviews.llvm.org/D105657

Files:
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/lib/Target/X86/X86FloatingPoint.cpp
  llvm/lib/Target/X86/X86InstrInfo.cpp
  llvm/test/DebugInfo/MIR/InstrRef/x86-fp-stackifier-drop-locations.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105657.359723.patch
Type: text/x-patch
Size: 15730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210719/f9fca366/attachment.bin>