[PATCH] D105657: [InstrRef][X86] Drop debug instruction numbers from x87 instructions

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 03:16:10 PDT 2021


djtodoro added a comment.

Hi @jmorse,

Thanks for this. It looks reasonable, but I was wondering if there is an automatic way for ensuring that when deletion of an operand occurs, there is no dangling debug ref to it. It seems like a good candidate for an assertion somehow? I guess we should be aware that this feature will be used for some downstream targets as well, so we need to provide some kind of mechanism for them in order to keep things valid, any thoughts?

Best,
Djordje


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105657/new/

https://reviews.llvm.org/D105657



More information about the llvm-commits mailing list