[PATCH] D105996: [AArch64] Enable Upper bound unrolling universally

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I'm not sure it is a good idea to enable it universally after just measuring on a single core in a single configuration. From the data you shared, it is not clear which build settings were used (-O3, -Os, LTO, PGO?) and it would also be good to specify what metric you are showing (score I guess, but it is not clear). For making such changes in general, I think it would be good to see data on as many impacted configurations as possible to rule out negative impacts. I am also curious what the impact is on -Os and it would also be good to check Geekbench.

Last time I measured this for Apple out-of-order cores, this was not really beneficial on a wider set of benchmarks, but things might have change. I'd recommend to only enable it for the cores you measured it (or cores you are confident that are very similar).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105996/new/

https://reviews.llvm.org/D105996