[PATCH] D105996: [AArch64] Enable Upper bound unrolling universally

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 00:28:47 PDT 2021


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

> It looks like there was hiccup on testing machine so the performance data is updated.

Oh OK, They do look better. It's standard in llvm to run the llvm-test-suite for reporting performance results, to test a wider range of cases. It can be quite noisy though, so you need to ensure the results are statistically significant.

This option sounds OK to me. I think it could probably be enabled universally as a part of runtime unrolling. But if it is a separate option I have no issues with enabling it for AArch64, and the results you have look OK. LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105996/new/

https://reviews.llvm.org/D105996



More information about the llvm-commits mailing list