[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

[Necip Fazil Yildiran via Phabricator via llvm-commits]

necipfazil abandoned this revision.
necipfazil added a comment.

In D105911#2878345 <https://reviews.llvm.org/D105911#2878345>, @morehouse wrote:

> Are comdats needed?  Can we get proper dead stripping with just `SHF_LINK_ORDER`?

It looks like we can. I am abandoning this revision. I will shortly push the changes to related revisions for not using comdats.

> @MaskRay recently updated the documentation for associated metadata <https://llvm.org/docs/LangRef.html#associated-metadata> to imply that our symbol doesn't need to share a comdat with its associated function when the function doesn't have a comdat.
>
> Also, @MaskRay: Can adding comdats like this change the final code in the fully-linked binary?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105911/new/

https://reviews.llvm.org/D105911