[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 14 14:17:13 PDT 2021


morehouse added a subscriber: MaskRay.
morehouse added a comment.

Are comdats needed?  Can we get proper dead stripping with just `SHF_LINK_ORDER`?

@MaskRay recently updated the documentation for associated metadata <https://llvm.org/docs/LangRef.html#associated-metadata> to imply that our symbol doesn't need to share a comdat with its associated function when the function doesn't have a comdat.

Also, @MaskRay: Can adding comdats like this change the final code in the fully-linked binary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105911/new/

https://reviews.llvm.org/D105911



More information about the llvm-commits mailing list