[PATCH] D104997: [AMDGPU] Deduce attributes with the Attributor

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:123
+    if (isDSAddress(C))
+      Result = DS_GLOBAL;
+
----------------
arsenm wrote:
> I don't know why you are tracking this here. This isn't entirely true anymore, plus there's a dedicated pass for this?
This is used for the deduction of `amdgpu-queue-ptr` attribute. For non entry entry functions if the function uses a  ds global (even transitively) it gets the amdgpuqueue-ptr attribute.
I tried to replicate what AnnotateKernelFeatures.cpp does since there isn't any documentation available about the attribute(as far as I know). 
How do you think we should proceed ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997