[PATCH] D104997: [AMDGPU] Deduce attributes with the Attributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:123
+    if (isDSAddress(C))
+      Result = DS_GLOBAL;
+
----------------
I don't know why you are tracking this here. This isn't entirely true anymore, plus there's a dedicated pass for this?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:226
+    bool InitialValue = false;
+    if (F->hasFnAttribute("uniform-work-group-size"))
+      InitialValue = F->getFnAttribute("uniform-work-group-size")
----------------
Braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997