[PATCH] D106147: [PredicateInfo] Use Intrinsic::getDeclaration now that it handles unnamed types.

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere created this revision.
jeroen.dobbelaere added reviewers: jroelofs, fhahn, nikic.
Herald added subscribers: ormris, hiraditya.
jeroen.dobbelaere requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a second attempt to fix the EXPENSIVE_CHECKS issue that was mentioned  In D91661#2875179 <https://reviews.llvm.org/D91661#2875179> by @jroelofs.

(The first attempt was in D105983 <https://reviews.llvm.org/D105983>)

D91661 <https://reviews.llvm.org/D91661> more or less completely reverted D49126 <https://reviews.llvm.org/D49126> and by doing so also removed the cleanup logic of the created declarations and calls.
This patch is a replacement for D91661 <https://reviews.llvm.org/D91661> (which must itself be reverted first). It only replaces the custom declaration creation with the generic version and shows the test impact.


https://reviews.llvm.org/D106147

Files:
  llvm/lib/Transforms/Utils/PredicateInfo.cpp
  llvm/test/Other/debugcounter-predicateinfo.ll
  llvm/test/Transforms/Util/PredicateInfo/condprop.ll
  llvm/test/Transforms/Util/PredicateInfo/diamond.ll
  llvm/test/Transforms/Util/PredicateInfo/edge.ll
  llvm/test/Transforms/Util/PredicateInfo/testandor.ll
  llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106147.359301.patch
Type: text/x-patch
Size: 37147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210716/04ed3d7a/attachment.bin>