[PATCH] D89009: Add version to libLLVM also on non-UNIX

Fri Jul 16 04:44:12 PDT 2021

mati865 added a comment.

In D89009#2882846 <https://reviews.llvm.org/D89009#2882846>, @mstorsjo wrote:

> In D89009#2857310 <https://reviews.llvm.org/D89009#2857310>, @mati865 wrote:
>
>> In D89009#2857228 <https://reviews.llvm.org/D89009#2857228>, @mstorsjo wrote:
>>
>>> Yep. I guess the question mainly is if we'd want to make this an upstream thing, adding an `if(UNIX)` around the symlinks on lines 608-613 here, if windows packaging cases would want to omit them anyway?
>>
>> I have no idea about guidelines for Windows but it'd make sense for me.
>
> @mati865 - Do you want to update the patch with an `if(UNIX)` around the symlink lines? I think we've got agreement that we can move forward with this, and it'd be nice to have it in before the 13.x branch in a couple weeks.

Sorry, I have forgotten to add this to my TODO.
I can do it over the weekend, ofc I won't mind if somebody beats it to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009