[PATCH] D105983: [PredicateInfo] return true when the function was modified

Fri Jul 16 04:16:58 PDT 2021

jeroen.dobbelaere added a comment.

In D105983#2880058 <https://reviews.llvm.org/D105983#2880058>, @fhahn wrote:

>> This fixes a bug that shows up with the old pass manager and EXPENSIVE_CHECKS. It was reported In D91661#2875179 <https://reviews.llvm.org/D91661#2875179> by @jroelofs
>
> Ok, so the reason is that `PredicateInfo` does not remove the declarations it created after D91661 <https://reviews.llvm.org/D91661> and also does not remove the `ssa_copy` calls? It might be better to restore the behaviour, otherwise we will have to update all passes that use `PredicateInfo` to mark the function/module as changed, which seems a bit unfortunate.

I see. The reverted patch did much more than just fix the name clashes in an ad hoc way.  Let me come up with patch that again cleans up what was produced.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105983/new/

https://reviews.llvm.org/D105983