[PATCH] D105983: [PredicateInfo] return true when the function was modified

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 07:18:35 PDT 2021


fhahn added a comment.

> This fixes a bug that shows up with the old pass manager and EXPENSIVE_CHECKS. It was reported In D91661#2875179 <https://reviews.llvm.org/D91661#2875179> by @jroelofs

Ok, so the reason is that `PredicateInfo` does not remove the declarations it created after D91661 <https://reviews.llvm.org/D91661> and also does not remove the `ssa_copy` calls? It might be better to restore the behaviour, otherwise we will have to update all passes that use `PredicateInfo` to mark the function/module as changed, which seems a bit unfortunate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105983/new/

https://reviews.llvm.org/D105983



More information about the llvm-commits mailing list