[PATCH] D106053: [CodeGen] Remove pending AssertZext AssertSext in promoting FP_TO_INT
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 15 20:14:40 PDT 2021
xiangzhangllvm added a comment.
> The same code also exists in X86TargetLowering::ReplaceNodeResults.
>
> My confusion is that at multiple points in this discussion you mentioned AssertZext being what's causing the problem, but this patch doesn't affected the AssertZext in the test.
My mistake, I thought only here adding the AssertZext.
The project is very sensitive, even I fine tuning the order of the IR, it will fail to reproduce. So after I apply this patch, it not reproduce too, So I thought the fix "really" works.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106053/new/
https://reviews.llvm.org/D106053
More information about the llvm-commits
mailing list